Code Review Please

[KRoss]

I been able to use Russ Code, and do three phases of light, but I want to introduce a few more options. I been trying to replicate my Graph I made, but I seem not to be able to determine why LED Evening and Sundown ever take place. Below is the code.

Set Off
If Sun 000/-600 Then LED_Sunrise
If Sun 120/-480 Then LED_Morning
If Sun 240/-240 Then LED_Noon
If Sun 480/-120 Then LED_Evening
If Sun 600/000 Then LED_Sundown
If Outlet Pre_Weather = ON Then PreWeather
If Outlet Clouds = ON Then Cloudy
If Outlet Storms = ON Then Stormy
If Outlet Post_Weather = ON Then PostWeather



My Assumption is 000 Sunrise, 2 hours later Morning, 2 Hours Later Noon, 2 Hour Later Evening and 2 Hours after that to the end Sundown. The - after is to ensure each one does not step on each other. Russ's graph that he once displayed was a great visual but I seem not to be able to get above 3.

Any help would be great.
Thanks

[BertL]

Have not figured out why yet... Will think on it, but Russ will probably figure it out in 2 seconds as his head seems to work the way an Apex does (that's a compliment, Russ!). ...but someone is sooner or later gonna ask, so you should post your sunrise/sunset times in your Season Table for at least the last couple of days... That's the other part of this equation we need to know.

[KRoss]

I am using The following Season Table for example today:

Jul 27

06:50/19:39

09:00/21:00

7

80.1

So My Assumption is:

06:50 LED_Sunrise
08:50 LED_Morning
10:00 LED_Noon
12:00 Then LED_Evening
14:00 Then LED_Sundown

I wish there was a way to figure out exactly mid day off the If SUN command. I actually will be adjusting for two more points, but first wanted to start with inserting two but at the end want to insert 4, I have the code to adjust cloudy, and storms based on the mode of lighting now.

[RussM]

Change the order:

If Sun 000/-360 Then LED_Sunrise
If Sun 120/-360 Then LED_Morning
If Sun 360/000 Then LED_Sundown
If Sun 360/-120 Then LED_Evening
If Sun 240/-240 Then LED_Noon

The midday statement MUST be last so it takes precedence over the others. Similarly, the morning line must come after the sunrise and the evening line must come after the sundown line. This is how you get the proper stepping.

If you sketch it out in the same manner as I did in the image you mentioned, it will help visual the overall effect.

Are you doing this so you can get more granular with the spectrum throughout the day?

[KRoss]

Thanks Russ,

Yes I am trying to add some more points to match my graph I showed in post your radion graph to adjust the spectrum. The one I posted was working great but wanted to introduce storms and clouds and the base code you provided was great having my pumps interact with the lights.

I want to add a total of 7-9 points.

Let me graph it out with all the points and post. My confusion is order but your explanation cleared that up.

[KRoss]

Russ, (First thanks for the help!!)

This was the final code I came up with. I even included a visual chart, am I correct on the logic?

If Sun 000/-360 Then LED_Sunrise
If Sun 120/-360 Then LED_Morning
If Sun 180/-360 Then LED_MidMorn
If Sun 360/000 Then LED_Sundown
If Sun 360/-120 Then LED_Evening
If Sun 360/-240 Then LED_Afternoon
If Sun 240/-300 Then LED_Noon
If Outlet Pre_Weather = ON Then PreWeather
If Outlet Clouds = ON Then Cloudy
If Outlet Storms = ON Then Stormy
If Outlet Post_Weather = ON Then PostWeather

Below is the Chart I did (Hopefully I am right)

[RussM]

Standby - I need to go swallow a handful of Excedrin to ward off the headache which looking at that will give me

[RussM]

The program is good, but the visualization is not quite right - the blocks for Afternoon and Evening should be swapped