Code to prevent skimmer overflowing?

[Crimsonvice]

I have had my skimmer overflow on me one too many times, and I want to try and use the high optical sensor on my ATK to turn off the skimmer when it is reached. Here is what I have so far:

Fallback OFF
Set ON
If FeedA 000 Then OFF
Defer 007:00 Then ON
If ATO_HI CLOSED Then OFF
Defer 007:00 Then OFF
If Output Maintenance = ON Then OFF
If Output ReturnPump = OFF Then OFF

I am thinking that this will leave my skimmer in the OFF state even once the low optical sensor is reached, is this correct? To turn it back on would I have to add this below the second defer line?

If ATO_HI OPEN Then ON
Defer 003:00 Then ON

[zombie]

I would do this.

Fallback OFF
Set ON
If FeedA 000 Then OFF
If ATO_HI CLOSED Then OFF
If Output Maintenance = ON Then OFF
If Output ReturnPump = OFF Then OFF
If Power Apex Off 001 Then OFF
Defer 007:00 Then ON




You might be an engineer if...You have no life and can prove it mathematically.

[Todd]

zombies is a good recommendation, but just to clarify some misconceptions that I see in your question: the DEFER statement applies to the entire outlet not the preceding statement, so multiple DEFERS of the same state don't work, the longest time prevails. So your proposed DEFER 003:00 Then ON would get overridden by the DEFER 007:00 Then ON. It doesnt matter where in the code they are placed, but for clarity I prefer them at the end. Also, your added ATO_HI OPEN command would be redundant to the SET ON. With a few exceptions, such as DEFER, the statements are evaluated top to bottom and any false statement is skipped. So by default, the outlet is ON unless one of the other statements changes it.

[Crimsonvice]

Thanks guys. This helps clear some things up. I am new to this so every little bit helps.

[rjkrejci]

Are you sure you want the "Defer 007:00 Then OFF" in there? That means if any of the "OFF" conditions becomes true, it will wait 7 minutes to turn the Skimmer off. Just making sure. Zombie's omits it and generally is my preferred way to organize code....have your SET be the default and all the conditions follow that could turn it to the opposite of the SET. And putting DEFERs last since they are overarching.

[Crimsonvice]

Are you sure you want the "Defer 007:00 Then OFF" in there? That means if any of the "OFF" conditions becomes true, it will wait 7 minutes to turn the Skimmer off. Just making sure. Zombie's omits it and generally is my preferred way to organize code....have your SET be the default and all the conditions follow that could turn it to the opposite of the SET. And putting DEFERs last since they are overarching.

I was just taking a guess. I am new to coding, so I haven't got everything down pat. That makes sense though. I appreciate the explanation.


Sent from my iPhone using Tapatalk