Thanks Zombie additional comments/questions in red
Comments in bold.
VO: ATO_Wait_Tst (test if ATO is in wait for evaporation 5 minutes mode before start AWC)
Set ON (set on makes sense for logic continuity where my tests all equal positive is satisfied, but could this set on be dangerous?)
If Sump_N OPEN Then OFF (if optical sump normal is not closed (I should have said Open instead of not Closed) ATO is waiting for 5 minutes to fill)
If Outlet ATO_Pump = ON Then OFF (ATO filling pump on, probably covered from above line but could prevent defer overlap)
This doesn't appear to be the right method. I would have this turn ON for 5 minutes if the ATO is currently ON or Sump_N is OPEN calling for water
Confused here. What I am trying to accomplish is waiting for an ATO "cycle" to finish at full. I don't want to start a water change when some evap water is missing. ATO is supposed to sense Sump_N open and wait 5 minutes for more evaporation so not turning PMUP on for short cycle. So if Sump_N is Open it must be waiting and if ATO_Pump is ON it is filling for a few seconds. When ATO_pump is OFF and SUMP_N is CLOSED then a "cycle" has just finished. I could reverse the logic ON/OFF states, but not sure why it it matters, seems more of a preference of how you think?
VO: AWC_Schedule (When I want AWC to happen, can change in one place and refer to anywhere)
Set OFF
If DoW SMTWTFS Then ON
If Time 21:00 to 20:00 Then OFF (if NOT 8-9pm then off)
VO: AWC_Drn_Tst (test if OK to drain change water)
Set OFF
If Output AWC_Schedule = ON Then ON
If Output ATO_Wait_Tst = ON Then OFF
If Salt_E OPEN Then OFF (another optical on salt mix holding tank, if empty don’t do a change)
Outlet: Sump_Drain (PMUP that sprays change water into skimmer cup, then flows to waste canister)
Fallback OFF
Set OFF
If Output AWC_Drn_Tst = ON Then ON
If Outlet Skim_Drain = OFF Then OFF (skimmer waste canister should be pumping out simultaneously)
This will cause problems. Remove the above line
I was questioning this, seemed like a safety. But if the Defer is wrong it will probably make something angry.
If Sump_W OPEN Then OFF (Optical for when the correct amount of change water removed, lower on ATK bracket)
If Sump_L OPEN Then OFF (Optical for sump should never be this low)
If Wst_H CLOSED Then OFF (Optical for skimmer waste canister full, stop Skim_Drain is not working)
Defer 000:05 Then OFF (defer OFF 5 seconds, Skim_Drain may get ahead and shut off briefly)
Min Time 060:00 Then OFF (don’t run again for 1 hour, so effectively 24hrs due to AWC_Schedule)
When On > 005:00 Then OFF (ran too long turn outlet OFF)
Also turn off for wet floor
Already Done
Outlet: Skim_Drain (PMUP in skimmer waste canister)
Fallback OFF
Set OFF
Remove set OFF
Oh Yes Duh!
If Wst_H CLOSED Then ON (Optical for waste canister is full of skimate so empty)
If Outlet Sump_Drain = ON Then ON (Sump_Drain is pumping into skimmer cup, no need to wait for Wst_H there is rising fluid level)
If Wst_L OPEN Then OFF (Optical for waste canister is empty stop PMUP)
Defer 000:02 Then ON
Defer 000:02 Then OFF
VO: AWC_Fil_Tst (test if removal of change water has completed, will make sense when looking at Outlet Salt_Pump)
Set OFF
If Output Sump_Drain = ON Then ON
Defer 020:00 Then OFF (holds state of sump drain ON logic for 20 minutes)
Outlet: Salt_Pump (PMUP that replaces water change)
Fallback OFF
Set OFF
If Output AWC_Fil_Tst = ON Then ON (VO above, Sump_Drain is on or was on up to 20 minutes ago)
If Output Sump_Drain = ON Then OFF (Sump_Drain is actually on so wait until off)
If Sump_N CLOSED Then OFF (Optical water level back to normal)
If Sump_H CLOSED Then OFF (Optical sump high error)
Defer 000:30 Then ON
Defer 000:05 Then OFF
Min Time 060:00 Then OFF (don’t run again for 1 hour, so effectively 24hrs when Sump_Drain state changes)
When On > 010:00 Then OFF
If Wet_F CLOSED Then OFF
Now I changed my initial ATO code slightly to use the AWC_Fil_Tst to keep the ATO off until the Salt_Pump should be done returning the sump to normal level. I think this could be improved for failsafe, but the run time limits and salinity monitor should keep things in check.
Outlet: ATO_Pump (from initial question)
Fallback OFF
Set OFF
If Sump_N OPEN Then ON
If Output AWC_Fil_Tst = ON Then OFF (only line changed)
Remove above line
If Sump_H CLOSED Then OFF
If Salt < 32.0 Then OFF
If RODI_E OPEN Then OFF
If ATO_On OPEN Then OFF
If Maint OPEN Then OFF
Add This
If Output Sump_Drain = ON Then OFF
If Output Salt_Pump = ON Then OFF
Only problem here is there is a 30 second defer between Sump_Drain and Salt_Pump and I think ATO would try to run (since Sump_N is OPEN). I think AWC_Fil_Tst will probably keep ATO off a little longer than needed, but I didn't see the harm in 20 minutes (which I could probably reduce after monitoring). Even if I removed the defer there, it might be a brief period between outlet on states changing and ATO trying to run? Maybe I should make a VO for this task, I'll think on that.
Defer 005:00 Then ON
Defer 000:10 Then OFF
Min Time 030:00 Then OFF
When On > 002:00 Then OFF
Glad the feedback on problems was isolated and I didn't create a pile of garbage.
Bookmarks